-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular 18 Update #2340
Angular 18 Update #2340
Conversation
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@laurentgrangier Please confirm whether JsonForms works for you with Angular 18 in this state. If yes, we'll merge this and do a release soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add the information about the angular upgrade in the migration document
@sdirix Good point! I added a Json Forms 3.3 section mentioning this to MIGRATION.md |
@lucas-koehler Thank you for the new PR and the upgrade to Angular 18 final version. I check JsonForms with Angular 18 and give you feedback quickly (should be this week). |
@lucas-koehler I tested JSONForms built on this branch with our software using Angular 17 and also using Angular 18 and had no problem with JSONForms. We only use jsonforms/core and jsonforms/angular. No other packages of jsonforms. |
9563337
to
0bfd686
Compare
Updates code base to Angular 18. This removes support for Angular 16. Also includes the following changes: - removal of the angular test package - Typescript update - migration guide entry Co-authored-by: Lucas Köhler <lkoehler@eclipsesource.com>
0bfd686
to
70e26f8
Compare
I also tested with React 18 in the Angular Seed application. That works 👍 |
Based on PR #2337 extended by using the Angular 18 release and regenerated pnpm lock file by me.