-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core): resolve circular dependencies #2345
refactor(core): resolve circular dependencies #2345
Conversation
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @LukasBoll , thanks for the PR ❤️
The changes already look mostly good to me and no more circular dependency warnings are shown :)
Besides two inline comments, I suggest renaming the folder stateToPropsMapper
to simply mappers
: Not all of the methods are mapping state to props but most of them map either state or dispatch to some kind of props or utility data structure.
0b6758f
to
6092386
Compare
Eliminated circular dependencies in the core module and reorganized package structure. Ref eclipsesource#2321
6092386
to
2dc1e47
Compare
Hi @lucas-koehler, Thank you for the review! I updated everything according to your suggestions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates @LukasBoll ! LGTM now :)
Eliminated circular dependencies in the core module and reorganized package structure.
Ref #2321