-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for "multiple" prop on Select (fixes #2347) #2356
Add support for "multiple" prop on Select (fixes #2347) #2356
Conversation
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jchamberlain , thanks for the contribution ❤️
The changes LGTM. Could you pleaserebase them onto the current master to get a (hopefully) clean run of the CI? Thanks!
f8306ef
to
ee3c12e
Compare
@jchamberlain I rebased the changes with Github's builtin functionality. The lint check fails because |
ee3c12e
to
7685c7d
Compare
Hey @lucas-koehler, formatting applied. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now. Thanks again for the contribution :)
Thanks, @lucas-koehler! I was going to start using it in my project directly via the master branch, but my ancient version of yarn doesn't like your monorepo (and I can't upgrade yarn just yet). How soon will you be publishing a new release tag? Anything that publishes the individual packages to NPM will work for me. Perhaps you could publish an alpha or beta? |
Hi @jchamberlain , I published a new alpha |
Perfect. Thank you! |
Here are the changes proposed in #2347.