Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove 'matchMedia' mock #2370

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

sdirix
Copy link
Member

@sdirix sdirix commented Aug 27, 2024

The 'matchMedia' mock was previously introduced to workaround the 'Hidden' component of Material UI not rendering in case media queries are not available in the environment.

With JSON Forms 3.3.0 we removed all usages of the 'Hidden' component so the 'matchMedia' mock is also no longer required.

Copy link

netlify bot commented Aug 27, 2024

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit a23e990
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/66cf378b0e5d2e0007e87eed
😎 Deploy Preview https://deploy-preview-2370--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

Coverage Status

coverage: 83.284% (-0.001%) from 83.285%
when pulling 8baefa6 on sdirix:remove-matchmedia-mock
into bd11754 on eclipsesource:master.

Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the cleanup ✨

The 'matchMedia' mock was previously introduced to workaround the
'Hidden' component of Material UI not rendering in case media queries
are not available in the environment.

With JSON Forms 3.3.0 we removed all usages of the 'Hidden' component
so the 'matchMedia' mock is also no longer required.
@sdirix
Copy link
Member Author

sdirix commented Aug 28, 2024

I rebased on master, no other changes

@sdirix sdirix merged commit a23e990 into eclipsesource:master Aug 28, 2024
8 checks passed
@sdirix sdirix deleted the remove-matchmedia-mock branch August 28, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants