Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Field API Loki variant with state types in driver #100

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

wertysas
Copy link

@wertysas wertysas commented Nov 21, 2024

This PR adds a new Field API Loki variant , dwarf-cloudsc-loki-scc-field, that applies Loki transformations to a driver with fields that are grouped and wrapped by derived types. The main changes are

And some CMake and bundle boilerplate. Note that the Loki version is changed from v.0.2.7 to v0.2.9

@wertysas wertysas marked this pull request as ready for review November 26, 2024 08:01
Copy link
Collaborator

@reuterbal reuterbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks, this is fantastic! I can confirm that it works on A100, produces correct results and expected performance.

One small request to fix the performance reporting, otherwise good to go!

Co-authored-by: Balthasar Reuter <6384870+reuterbal@users.noreply.github.com>
Copy link
Collaborator

@reuterbal reuterbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Confirmed working and performance reporting looks good.

Copy link
Collaborator

@mlange05 mlange05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic! What a great PR to get the century PR tag and end the year with. Many thanks to @wertysas and @reuterbal for final review and integration. GTG from me. :shipit:

@reuterbal reuterbal merged commit 751a953 into develop Dec 19, 2024
32 checks passed
@reuterbal reuterbal deleted the je-field-api-offload-v2 branch December 19, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants