Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged versions from CY49T2 and CY49R1 for CY50 #171

Closed
wants to merge 14 commits into from

Conversation

AlexandreMary
Copy link
Contributor

@AlexandreMary AlexandreMary commented Nov 13, 2024

This series of commits results from changes commited in ectrans for CY49T2, merged with the version of ectrans from CY49R1 (in the contrib/ directory of ifs-source).

The final commit 00cdb6e, tagged for-CY50 in ACCORD-NWP fork of ectrans, is the version bundled for CY50 at first (a version merged with a more recent version of ectrans, could be later bundled).

Note: past CY50, contributions from ACCORD consortium or MF to ectrans will be PR'ed directly and without so much delay to the main branch of this repo.

@FussyDuck
Copy link

FussyDuck commented Nov 13, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 5 committers have signed the CLA.

✅ AlexandreMary
✅ ddegrauwe
❌ Daan Degrauwe
❌ RyadElKhatibMF
❌ walidchikhi


Daan Degrauwe seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@samhatfield samhatfield changed the base branch from main to develop November 13, 2024 14:36
@samhatfield
Copy link
Collaborator

Hi @AlexandreMary - I have merged your branch with develop to remove the conflicts, and opened a new PR. If it's okay with you, I'll close this PR so we can discuss the changes in the other PR.

@AlexandreMary
Copy link
Contributor Author

OK Sam, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants