Improve error handling for GPU code path unimplemented features #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t yet implemented
…ths, rather than MPL_ABORT
wdeconinck
force-pushed
the
feature/error_handling
branch
from
cce2be1 to
76eb4a2
Compare
samhatfield
reviewed
Dec 19, 2024
Comment on lines
+293
to
+298
| R%NDGL = NPROC | ||
| ! Make even and positive | ||
| IF (MOD(R%NDGL,2) /= 0) THEN | ||
| R%NDGL = NPROC+1 | ||
| ENDIF | ||
| R%NDGL = MAX(2,R%NDGL) |
There was a problem hiding this comment.
What's the purpose of this block?
samhatfield
reviewed
Dec 19, 2024
Comment on lines
+388
to
+389
| R%NSMAX=1 | ||
| R%NTMAX = R%NSMAX |
There was a problem hiding this comment.
Likewise, what are these two lines for?
samhatfield
reviewed
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All following changes are required to more gracefully integrate ectrans GPU code paths in atlas via transi.
Workaround to avoid some unimplemented gpu-code path features:
The workarounds consists in ignoring the "ONLY" setup and setting everything up with a low truncation or grid resolution. Not ideal but a sufficient temporary solution.
This avoids special handling in downstream code like Atlas that would otherwise perform the same tricks.
Calling of ABORT_TRANS for other unimplemented gpu-code path features:
Now we don't get obscure errors or segfaults in lower-level code paths
Unsupported known gpu code paths called from within transi are now protected explicitly with error return codes rather than hard failures that cannot be recovered from. These error return codes should be removed as features are implemented of course:
- trans_vordiv_to_UV
- trans_dirtrans_adj
- trans_invtrans_adj
- trans_setup with llatlon=true
This now means that atlas unit-tests can choose to ignore unimplemented features via exception handling