Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output of the model is very sensitive to the bathymetry and obstruction coefficients. Previously, these were both computed by create_bathymetry, and the resulting bathymetry files were cached in nexus (https://get.ecmwf.int/#browse/browse:ecwam:data%2Fbathymetry%2Fv1%2Fbathymetry_O1280_nfre29_ETOPO1_e6c62ffa77b1815082065ffb241be879.gz). Preproc would then read this bathymetry file and generate the subgrid files. Repeatable results across different compilers and architectures were thus achievable as long as the same bathymetry file was used.
Now that grib output is enabled, create_bathymetry rather than preproc computes the grids, and outputs the subgrid files in grib. Therefore the subgrid files now also have to be cached in nexus in order to get repeatable results across different compilers. This PR makes the necessary changes to the scripts to achieve this.
Right now, I have only uploaded the bathymetry and subgrid files for the O48 grids to nexus. As this is a new caching approach they are in the v2 folder. Older versions of ecwam that don't use grib output will continue to use the bathymetries in the v1 folder. Once the PR is approved I will upload the bathymetries and subgrids for the O320, O640 and O1280 grids too.
This PR also adds single precision validation hashes for the O320 test case.