Restore POINTER attribute to COPY_DIM_CONTIGUOUS dummy args #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v0.2.1 and v0.2.2, the dummy arguments
HST,DEV
in theCOPY_DIM_CONTIGUOUS
subroutine had the pointer attribute. This was accidentally removed (apologies!) in the CUDA PR.Without the
POINTER
attribute, the runtime reshapes the dummy args so that the LBOUNDS are always 1, rather than the true LBOUNDS ofSELF%PTR
andSELF%DEVPTR
. This doesn't cause any problems in most cases, which explains why this went unnoticed. The only case it fails for is whenCHILD%DEVPTR
is a discontiguous slice ofGANG%DEVPTR
and we try and do per-child copies.Even though we don't plan on introducing per-child copies to the master branch in the near future, I still think this change should be reverted because: