Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update buddy_alloc.h #48

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Conversation

pmarguinaud
Copy link
Collaborator

There is a bug in buddy_alloc.h; it cannot handle very large memory sections.

Increasing DEV_ALLOC_SIZE to 120Gb highlights the problem :

$ DEV_ALLOC_SIZE=120000000000 make test
...
The following tests FAILED:
          1 - main.x (Subprocess aborted)
          4 - reshuffle_lastdim.x (Subprocess aborted)
          6 - test_statistics.x (Subprocess aborted)
          7 - test_sizeof.x (Subprocess aborted)
          8 - test_bc.x (Subprocess aborted)
          9 - reshuffle.x (Subprocess aborted)
         10 - test_wrappernosynconfinal.x (Subprocess aborted)
         11 - test_field1d.x (Subprocess aborted)
         13 - async_host.x (Subprocess aborted)
         14 - cpu_to_gpu.x (Subprocess aborted)
         15 - cpu_to_gpu_delayed_init_value.x (Subprocess aborted)
         16 - cpu_to_gpu_init_value.x (Subprocess aborted)
         17 - delete_device_wrapper.x (Subprocess aborted)
         20 - final_wrapper_gpu.x (Subprocess aborted)
         23 - get_stats.x (Subprocess aborted)
         25 - get_view_get_device_data.x (Subprocess aborted)
         32 - init_owner_delayed_gpu.x (Subprocess aborted)
         37 - init_owner_init_debug_value_gpu.x (Subprocess aborted)
         38 - init_owner_init_delayed_debug_value_gpu.x (Subprocess aborted)
         39 - init_owner_init_delayed_value_gpu.x (Subprocess aborted)
         46 - init_wrapper_non_contiguous_multi.x (Subprocess aborted)
         47 - no_transfer_get_device.x (Subprocess aborted)
         52 - sync_device.x (Subprocess aborted)
         53 - sync_host.x (Subprocess aborted)
         54 - test_crc64.x (Subprocess aborted)
         55 - wrapper_modify_gpu.x (Subprocess aborted)
         56 - test_gang.x (Subprocess aborted)

Using the latest version of buddy_alloc.h solves the issue.

This problem has been discussed with the developper of buddy_alloc in this thread :

spaskalev/buddy_alloc#105

Copy link
Collaborator

@awnawab awnawab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks @pmarguinaud for chasing this with the buddy_alloc's developer and for filing the fix! 🙏

@awnawab awnawab merged commit 7c8e68b into ecmwf-ifs:main Jun 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants