Transformations: Test and fix corner case in get_local_arrays #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running get_local_arrays over the spec of a subroutine we were erroneously picking up component arrays of derived-type arguments that were used for shape definitions. This extends the test for this corner case and fixes it.
|
Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/355/index.html |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #355 +/- ##
=======================================
Coverage 95.36% 95.36%
=======================================
Files 173 173
Lines 36896 36900 +4
=======================================
+ Hits 35185 35189 +4
Misses 1711 1711
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
awnawab
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is a small bug fix to #354 that was overlooked and is currently breaking H24-physics regression.
When running get_local_arrays over the spec of a subroutine we were erroneously picking up component arrays of derived-type arguments that were used for shape definitions. This extends the test for this corner case and fixes it.