Handle Loki dimension pragmas for modules (and not only routines) for FP #417
Conversation
|
Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/417/index.html |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #417 +/- ##
=======================================
Coverage 93.04% 93.05%
=======================================
Files 198 198
Lines 39320 39359 +39
=======================================
+ Hits 36587 36627 +40
+ Misses 2733 2732 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| def to_str(expr): | ||
| return str(expr).lower().replace(' ', '') |
There was a problem hiding this comment.
This looks like we're missing a StrCompareMixin somewhere?
There was a problem hiding this comment.
Yes, but that's an (internally) know issue; we don't force StrCompareMixin on pure operations (Sum, Product, etc.). We could, probably, but beyond this PR I'd argue? Maybe we need a separate (formal) issue on this though?
There was a problem hiding this comment.
Yes fully agreed - I didn't mean to imply this needs to be actioned here. Documenting this in an issue would be a good idea, though.
reuterbal
added
the
ready to merge
Infer shape via Loki dimension pragmas, e.g.,
not only for routines but also for modules (FP only).