Replaced default python-requests user-agent with a custom ones #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can improve analytics and QOS a bit
|
|
|
Hi @keul , |
|
@EddyCMWF I think it can still be relevant. At the time I was trying to intercept users using the cdsapi, while right now there's not way to differentiate them from other people using "vanilla" Python requests. If you think it can be useful I can fix conflicts |
|
This should be merged asap |
gbiavati
approved these changes
Feb 28, 2023
gbiavati
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default user-agent sent by cdsapi is inherited from it's dependency python-requests, which is python-requests/x.y.z
So it's not easy to know if the request came from official cdsapi or another Python code script that use python-requests under the hood.
Changing this can improve log analysis and QoS a bit (at least for 99% of users).
HTTP access log will now contains a user-agent field like the following: