Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature list depth option #34

Open
wants to merge 63 commits into
base: develop
Choose a base branch
from
Open

Feature list depth option #34

wants to merge 63 commits into from

Conversation

mcakircali
Copy link
Contributor

No description provided.

mcakircali added 30 commits August 8, 2024 09:51
@mcakircali
test(toKey): add check step value
862778c
@mcakircali
feat(list): cherry-pick level
d60aeb8 
from Simon branch
@mcakircali
test(fdb-list): add new
d23778c
@mcakircali
test(fdb-list): prepare grib file
3be1f22
@mcakircali
fix(fdb-list): init class member
e0a0421
@mcakircali
fix(fdb-list): unnecessary copy in loop
c2703ab
@mcakircali
fix(fdb-list): use make_unique not "new"
36e6a54
@mcakircali
fix(fdb-list): use "override" (not virtual)
77e3d77
@mcakircali
fix(fdb-list): default member init and tab size
1e3381b
@mcakircali
test(fdb-list): added --depth option
7f6be88
@mcakircali
fix(ListVisitor): empty keys
5dfb6a0
@mcakircali
style(fdb-list): clean code
71bbf51
@mcakircali
fix(fdb-list): porcelain defaults other options
c4ebc5b
@mcakircali
chore(remote/Handler): todo list w/ level
8ce657e
@mcakircali
feat(list)!: separate ListElement
8d9db4e 
implements ctor for 1-,2-,3-level split key chains
[skip-ci]
@mcakircali
fix(ListVisitor): use discrete ListElement ctor for DB, Cat, and Datum
fb4b8a0
@mcakircali
fix(FDB): missing include
2c2b79d
@mcakircali
fix(FDB): name collisions
31edc16
@mcakircali
fix(FDB): unnecessary copy in loop
376d842
@mcakircali
fix(FDB): after new ListElement
4a81dad
@mcakircali
fix(FDB): 'some' include issues
e5edc6c 
cleanup and add missing
@mcakircali
chore(c api): param should be sha1
81a3924
@mcakircali
fix(c api): splitkey iterator
6d67ae6 
reworked it to behave more like an iterator
@mcakircali
fix(fdb-patch): after ListElement
b68231b
@mcakircali
fix(fdb-list): includes
a0cb5fa
@mcakircali
feat(fdb-list): options; assert depth and porcelain text
dbf974e
@mcakircali
fix(fdb-list): keys api
4595fa7
@mcakircali
fix(FieldLocation): remove nullLocation
7c42889
@mcakircali
fix(MultiRetrieveVisitor): include issues
f41ca4d
@mcakircali
feat(remote): added level to Handler
70768b9
@mcakircali mcakircali requested a review from simondsmart August 8, 2024 08:44
@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 79.92565% with 54 lines in your changes missing coverage. Please review.

Project coverage is 64.10%. Comparing base (7f8e64c) to head (5aca515).

Files with missing lines Patch % Lines
src/fdb5/api/helpers/ListElement.cc 48.21% 29 Missing ⚠️
src/fdb5/tools/fdb-list.cc 67.56% 12 Missing ⚠️
src/fdb5/api/RemoteFDB.cc 0.00% 6 Missing ⚠️
src/fdb5/database/KeyChain.h 85.00% 3 Missing ⚠️
src/fdb5/remote/Handler.cc 0.00% 2 Missing ⚠️
src/fdb5/api/helpers/ListElement.h 75.00% 1 Missing ⚠️
src/fdb5/tools/fdb-patch.cc 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop      #34      +/-   ##
===========================================
+ Coverage    63.84%   64.10%   +0.26%     
===========================================
  Files          237      239       +2     
  Lines        13583    13675      +92     
  Branches      1325     1330       +5     
===========================================
+ Hits          8672     8767      +95     
+ Misses        4911     4908       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcakircali mcakircali marked this pull request as ready for review August 8, 2024 08:57
simondsmart
simondsmart requested changes Aug 13, 2024
View reviewed changes
src/fdb5/api/helpers/ListElement.cc Outdated Show resolved Hide resolved
src/fdb5/api/helpers/ListElement.cc Outdated Show resolved Hide resolved
src/fdb5/api/helpers/ListElement.h Outdated Show resolved Hide resolved
src/fdb5/api/helpers/ListElement.h Outdated Show resolved Hide resolved
src/fdb5/api/helpers/ListElement.h Outdated Show resolved Hide resolved
src/fdb5/tools/fdb-list.cc Show resolved Hide resolved
src/fdb5/tools/fdb-list.cc Outdated Show resolved Hide resolved
tests/fdb/api/test_fdb_c.cc Outdated Show resolved Hide resolved
tests/fdb/api/test_fdb_c.cc Show resolved Hide resolved
src/fdb5/api/local/ListVisitor.h Outdated Show resolved Hide resolved
@mcakircali mcakircali requested a review from simondsmart August 14, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simondsmart simondsmart Awaiting requested review from simondsmart

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcakircali @codecov-commenter @simondsmart