Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix replace new with make shared #39

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mcakircali
Copy link
Contributor

No description provided.

@mcakircali mcakircali requested a review from danovaro September 19, 2024 08:37
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.85%. Comparing base (7f8e64c) to head (6096a48).

Files with missing lines Patch % Lines
src/fdb5/rules/Schema.cc 90.90% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #39      +/-   ##
===========================================
+ Coverage    63.84%   63.85%   +0.01%     
===========================================
  Files          237      237              
  Lines        13583    13582       -1     
  Branches      1325     1325              
===========================================
+ Hits          8672     8673       +1     
+ Misses        4911     4909       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants