rule schema key #48
Draft
rule schema key #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from Simon branch
implements ctor for 1-,2-,3-level split key chains [skip-ci]
cleanup and add missing
reworked it to behave more like an iterator
polymorphic Rule
related to PR #26
(unfortunate iterator)
undo catalogue from api, instead canonicalize request
added tidy()
Ozaq
reviewed
Nov 18, 2024
Comment on lines
+50
to
54
| options_.push_back( | ||
| new SimpleOption<bool>("porcelain", | ||
| "Streamlined and stable output. Useful as input for other tools or scripts." | ||
| "Incompatible with options: location, timestamp, and length")); | ||
| options_.push_back(new SimpleOption<bool>("json", "Output available fields in JSON form")); |
There was a problem hiding this comment.
Since you already updated the doc: This also needs to mention the interaction of --json with --porcelain and the resulting incompatibilities
Ozaq
reviewed
Nov 18, 2024
Comment on lines
+93
to
+95
| fdb5::ListIterator list(const fdb5::FDBToolRequest& /* request */, const int level) override { | ||
| counts_.list += 1; | ||
| ASSERT(level == 3); |
There was a problem hiding this comment.
That seems odd, why take a param and assert its 3?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.