Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote fdb #54
base: develop
Are you sure you want to change the base?
Remote fdb #54
Changes from 198 commits
7a593ab
8fc61a7
1d65ce7
b6691d5
337cc51
d5f9ae8
563d1ad
020ce9f
e9df4ee
8b4a464
d6a0003
cee3a23
618e3da
4908bc5
2e8d795
6a2843d
40e783f
6c7c24b
2d6666f
9894117
eb715c0
79e22bf
69e2b9d
dfb54b4
8ab2cc2
e5c17d7
8eee95e
da0a0f7
40fcf66
d46037c
75e8aa9
77af845
5b4c9dc
3df7fb7
1827694
06339d3
0da176a
42c4f08
1a0bec2
2943da3
c132acc
4adcf41
20e580a
08a4b86
399a344
3e18426
2572484
562a1b9
00c3527
fc61ce1
41a34ad
5e90127
d51e189
d9937fa
1da7376
8170786
ecf3f43
9473df2
de5d324
e094c0f
f4c6320
ed0ad67
4d030a9
49a81e3
830fedc
6fb345f
9438332
25cb578
3a23919
49a2365
b1ae035
f2b7251
5284b99
44370ca
10fc5e8
476a1ec
2ff5a35
bcd5d90
33b7bea
3647975
786a777
14d2d9a
d0c0cdb
5a3bc9a
87ccf55
46d4166
d3afd34
ec5e557
b5c2a77
9ac8b94
d08408c
c89ada3
4fb2629
f529745
04c5501
1054385
b8085b2
2a3fac1
17a9bcb
a284d06
cc3f2fa
75e7cdc
9f29eaf
e97ebc8
e8baf96
6c3ff1b
26344a8
2700124
e8413de
856cdc5
54bd06e
d52e86a
3c10fa9
6034b72
e1e2dd4
3667c5e
87948df
b1d04ef
63dfd6d
36ad610
17ae0bb
a6dd9ec
a59cff6
ac9d98f
b3e6111
395596e
4b6fe5c
f1bdbec
12ff64a
cf314bb
ecf4d33
78622a1
f1c8115
e2f4834
f1360ae
049e11b
7fdc98b
36e7bc9
5df53a6
9c0f629
f90b99d
6c991d7
2758dc3
bb8557f
5cd3a51
7fe0f17
f6ff5df
ac05187
183e257
49a2f13
b49b2a1
b2d9c6b
df121a0
31e553e
3c7f4ec
b39ee3d
b6e225f
df54644
1e3b158
2a07281
254ed76
6631185
2d25663
90ea48a
5a18659
6d99a27
0b12259
c21f5f3
07e4d3b
2832638
7f1fd53
4bbd91c
9e80e07
6263ddd
3f57dd4
84cdfd4
27ad205
2d3ce4d
4c1ac8d
3825bb6
253a432
7ec275b
f8652cb
0d61134
52a8746
ae94a85
a0087c2
29ba56c
a7dd7e5
e32c79d
07dc074
5d83a55
2f048df
fdaa5d4
f2ed166
8397826
872573a
d0af10f
9057f3e
db308cf
9d2bebd
99d130a
e5f2ace
f4245dc
49dcda0
b64b924
7e03919
46508f3
b70c849
43ce247
5974d92
598a1d7
10d10b0
5a6a08f
4ea6a5b
b07fa9f
92e37c7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this warrants an explanation why this FDB type does not allow axes iteration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should really by done in a separate overload or even different function. This way you also do not break the existing interface and retain backward compatibility. Although the more adequate fix is to not expose the distinction between seekable and non-seekable FDB through the interface.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RemoteFDB only supports a subset of the interface and throws a NotImplemented exception that will reach caller code. I think this is a surprising design as the Exception is unexpected (nothing in the interface indicates that behavior) and also not very descriptive. Not implemented can have several meanings, at a bare minimum the exception should be translated into a "NotSupportedForThisDBType" exception. It would be nice to be able to programmatically inspect for capabilities, e.g. have something such has
bool supports_wipe()
.