Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix mistake in normal_effective_temperature() #37

Closed
wants to merge 1 commit into from

Conversation

34j
Copy link

@34j 34j commented Jul 17, 2024

@FussyDuck
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@34j 34j changed the title fix: fix normal_effective_temperature() fix: fix mistake in normal_effective_temperature() Jul 17, 2024
@34j 34j deleted the patch-1 branch November 11, 2024 09:59
@tlmquintino
Copy link
Member

Hi. Many thanks for your PR -- this was definitely a mistake of parenthesis in the wrong location.
I've reimplemented myself instead of merging your change since you hadn't signed our CLA, and Ive corrected the unit tests.
This is now part of the merge in #38 and the 2.1.0 released today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants