fix: optimize arraydiff perf in first render and clear #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we are using an O(ND) diff algorithm(Myers' Diff Algorithm) in the SVG renderer. But when we do first render or clear all things on canvas. The complex becomes O(N2) because the difference is the whole N. Which will cause a significant performance drop. Especially we can't avoid the first render. So in this PR, I did a simple optimization to handle these two cases. The time of the first frame render comes down to 100ms from the terrible 3000ms for 10k objects.
Also, I found an existing bug that appears after the change in #829 and fixed it.