feat(ssr): add emphasis style in ssr css apache/echarts#18334 #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ovilia
changed the title
Ovilia
requested review from
pissang and
plainheart
and removed request for
pissang and
plainheart
8 tasks
plainheart
reviewed
Apr 21, 2023
src/svg/cssEmphasis.ts
Outdated
| if (!el.ignore && el.__metaData) { | ||
| const empahsisStyle = el.states.emphasis | ||
| ? el.states.emphasis.style | ||
| : {}; |
There was a problem hiding this comment.
It seems the emphasis.disabled option is not being respected. The chart still highlights the item that the emphasis state is disabled.
100pah
requested changes
May 14, 2023
100pah
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See apache/echarts#18334