fix attribute resolver on promoted properties #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgafka
reviewed
Jul 18, 2024
| try { | ||
| $carry[] = $attribute->newInstance(); | ||
| } catch (Error) { | ||
| // Do nothing: it is an attribute targeting a parameter promoted to a property |
There was a problem hiding this comment.
That's assumption that this is the error :). We may be swallowing others errors too.
If we can't check by exception type, can we do an message type check e.g. string contains cannot target property?
dgafka
reviewed
Jul 18, 2024
| } catch (Error $e) { | ||
| if (\preg_match("/Attribute \"(.*)\" cannot target property/", $e->getMessage())) { | ||
| // Do nothing: it is an attribute targeting a parameter promoted to a property | ||
| } else { |
There was a problem hiding this comment.
Can we also apply this to TypeResolver#86? It's other way around there and we ignore all exceptions.
There was a problem hiding this comment.
Ha, you found it ! I knew it was done elsewhere.
dgafka
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow attributes targeting parameters to be used on php>8 promoted properties
Fixes #336
Type of change