Drop unnecessary InterfaceToCall references in container #348
Conversation
| public function getInterfaceToCall(): InterfaceToCall | ||
| { | ||
| return $this->interceptedMessageProcessor->getInterfaceToCall(); | ||
| return InterfaceToCall::create($this->getObjectToInvokeOn(), $this->getMethodName()); | ||
| } |
There was a problem hiding this comment.
I supposed MethodInvocation was public API, so I kept getInterfaceToCall() in the interface and used this fallback.
There was a problem hiding this comment.
This will now need to resolve the Interface using reflection on run time. Let's drop this method then, so we won't accidentally use it.
There was a problem hiding this comment.
Feel free to merge and do it as follow up
jlabedo
changed the title
jlabedo
changed the title
jlabedo
force-pushed
the
drop-unnecessary-interface-to-call-references
branch
from
43260fc to
b92564a
Compare
|
I can see in benchmark having better performance on run time with symfony, which dumps the container. I wonder what's the reasoning behind it. |
Maybe, this is the only rationale I have. But yes, InterfaceToCall may be quite expensive to load as there are a lot of objects to get from the container (InterfaceParameters and attributes) |
Description
InterfaceToCall are actually registered in the container, and there is a lot of registrations (InterfaceToCall, InterfaceParameter, Attributes).
This PR avoids injecting unnecessary InterfaceToCall references for service activators.
On a medium sized symfony project, I got 1000 objects dropped from the container after this PR, and got a 10% speed boost on cache:clear.
Type of change