Kafka message channel #407
Conversation
| @@ -2,7 +2,7 @@ version: "3.8" | |||
|
|
|||
| services: | |||
| app: | |||
| image: simplycodedsoftware/php:8.3.13 | |||
| image: simplycodedsoftware/php:8.3.10 | |||
There was a problem hiding this comment.
There is no 8.3.13, that had to be some bug
| /** | ||
| * licence Enterprise | ||
| */ | ||
| final class KafkaChannelAdapterTest extends TestCase | ||
| { | ||
| public function test_sending_and_receiving_from_kafka_topic(): void | ||
| { | ||
| $this->markTestSkipped('CI yet to be setup'); | ||
| $this->markTestSkipped('Kafka not yet supported'); |
There was a problem hiding this comment.
I do have to disable those tests on CI, because consumption does not work for some reason.
Locally it does work as expected.
@lifinsky any thoughts?
There was a problem hiding this comment.
What was the error during CI?
There was a problem hiding this comment.
There is no specific error, it just does not see any messages.
Either the topic is not available, or the consumer is somehow not able to consume the messages
| @@ -90,7 +90,7 @@ public function requeue(): void | |||
| // what to do here? | |||
| // $this->consumer->pausePartitions([$this->message->partition]); | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
This is using Kafka as Queue based mechanism, because in reality this message is still in the topic.
But, ye I will most likely follow on this. This make sense for Message Channels, where there is only single consumer group.
It does not make sense however for Inbound Adapter, as in there we may consume from topic that is consumed by multiple consumer groups. So republishing it to the same topic, could affect other parties
Why is this change proposed?
This provides Kafka as Message Channel
Pull Request Contribution Terms