This repository has been archived by the owner on Jun 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 115
Return more readonly components #233
Merged
+96
−11
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
3731762
Fix getComponent type
sheepsteak 2a921e4
Update Entity getComponent tests for development and production
sheepsteak 5fefe49
Allow getMutableComponent to return undefined
sheepsteak 6d8bdc2
Change getRemovedComponent to return readonly component
sheepsteak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,7 +43,11 @@ export class Entity { | |
} | ||
|
||
getRemovedComponent(Component) { | ||
return this._componentsToRemove[Component._typeId]; | ||
const component = this._componentsToRemove[Component._typeId]; | ||
|
||
return process.env.NODE_ENV !== "production" | ||
? wrapImmutableComponent(Component, component) | ||
: component; | ||
} | ||
|
||
getComponents() { | ||
|
@@ -60,6 +64,11 @@ export class Entity { | |
|
||
getMutableComponent(Component) { | ||
var component = this._components[Component._typeId]; | ||
|
||
if (!component) { | ||
return; | ||
} | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No point going through queries if the component does not exist. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nice catch yep |
||
for (var i = 0; i < this.queries.length; i++) { | ||
var query = this.queries[i]; | ||
// @todo accelerate this check. Maybe having query._Components as an object | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think this will be annoying? Should these functions throw an error (in development mode?) instead if the component does not exist?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's valuable to return
undefined
so you could check in your code if it exist or not instead of catching an error