Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements #4

Merged
merged 24 commits into from
Aug 14, 2023
Merged

Improvements #4

merged 24 commits into from
Aug 14, 2023

Conversation

Paebbels
Copy link
Member

@Paebbels Paebbels commented Feb 28, 2022

Changes

  • Added typehints
  • Added check is_dir() to list comprehension.
  • Merged multiple calls to print and used dedent together with f-strings.
  • Marked functions with @export so they get auto documented.

pyEDAA/Launcher/__init__.py Outdated Show resolved Hide resolved
pyEDAA/Launcher/__init__.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

❗ No coverage uploaded for pull request base (dev@645e27a). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             dev       #4   +/-   ##
======================================
  Coverage       ?   43.20%           
======================================
  Files          ?        1           
  Lines          ?       81           
  Branches       ?       16           
======================================
  Hits           ?       35           
  Misses         ?       43           
  Partials       ?        3           
Flag Coverage Δ
unittests 43.20% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Paebbels Paebbels force-pushed the paebbels/improvements branch 2 times, most recently from f1c1aea to 45bbe5f Compare March 1, 2022 00:18
@Paebbels Paebbels marked this pull request as ready for review August 14, 2023 21:33
@Paebbels Paebbels merged commit 1fda0fc into dev Aug 14, 2023
25 of 29 checks passed
@Paebbels Paebbels deleted the paebbels/improvements branch August 14, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant