Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/dynamic curl options #110

Merged
merged 2 commits into from
Jan 19, 2021
Merged

feat/dynamic curl options #110

merged 2 commits into from
Jan 19, 2021

Conversation

tobiasbambullis
Copy link
Contributor

No description provided.

@tobiasbambullis tobiasbambullis marked this pull request as draft July 31, 2020 12:04
@coveralls
Copy link

coveralls commented Jul 31, 2020

Coverage Status

Coverage increased (+0.05%) to 81.844% when pulling aa77a12 on tobiasbambullis:fix/dynamic-curl-options into b69afbc on edamov:master.

@tobiasbambullis tobiasbambullis marked this pull request as ready for review July 31, 2020 12:56
@lvandyk
Copy link

lvandyk commented Jan 19, 2021

Can we please merge this pull request? I'm having SSL issues: SSL certificate problem: unable to get local issuer certificate and would like to disable VERIFY_PEER on cURL.

@edamov edamov merged commit 9078598 into edamov:master Jan 19, 2021
@edamov edamov added this to the 0.12.1 milestone Jan 19, 2021
@lvandyk
Copy link

lvandyk commented Jan 20, 2021

Thank you for the quick turn around Arthur (and this awesome library)!

@rekliner
Copy link

rekliner commented Feb 4, 2021

Just confirming for anyone else that this fixed my ssl issues that mysteriously cropped up in the last month with apple. Adding the option to the instantiation fixed it like below. Thank you for making the world a better place one repository at a time!
$client = new Client($authProvider, $production = true, [CURLOPT_SSL_VERIFYPEER=>false]);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants