Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds optional linear LR schedule to the example #157

Merged
merged 4 commits into from
Dec 4, 2023
Merged

Adds optional linear LR schedule to the example #157

merged 4 commits into from
Dec 4, 2023

Conversation

Ivan-267
Copy link
Collaborator

@Ivan-267 Ivan-267 commented Dec 1, 2023 •
edited
Loading

Adds a linear LR schedule which I started using for my environments.

Completed:

  • testing
  • mentioning the option in docs.

@Ivan-267 Ivan-267 marked this pull request as ready for review December 1, 2023 16:35
@Ivan-267 Ivan-267 requested a review from edbeeching December 1, 2023 16:35
@Ivan-267 Ivan-267 added the enhancement New feature or request label Dec 3, 2023
edbeeching
edbeeching approved these changes Dec 3, 2023
View reviewed changes
Copy link
Owner

@edbeeching edbeeching left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this and fixing typos.
LGTM!

@Ivan-267 Ivan-267 merged commit 010d05b into main Dec 4, 2023
@Ivan-267 Ivan-267 deleted the sb3_example_add_lr_schedule branch December 4, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edbeeching edbeeching edbeeching approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ivan-267 @edbeeching