Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n and better handling for invalid modules #59

Merged
merged 35 commits into from
Mar 25, 2020
Merged

i18n and better handling for invalid modules #59

merged 35 commits into from
Mar 25, 2020

Conversation

Lextum
Copy link
Collaborator

@Lextum Lextum commented Mar 5, 2020

No description provided.

Lextum added 21 commits February 26, 2020 13:37
@Lextum Lextum requested a review from eddex March 5, 2020 15:34
@eddex
Copy link
Owner

eddex commented Mar 6, 2020

why does this PR include all changes from PR #58??

@Lextum
Copy link
Collaborator Author

Lextum commented Mar 6, 2020

why does this PR include all changes from PR #58??

Because i needed them, for 8a221f1 and 7a14fa5

@Lextum Lextum changed the title another fix for modules with strange names Skipping invalid modules Mar 6, 2020
eddex
eddex requested changes Mar 6, 2020
View reviewed changes
src/components/i18n.js Outdated Show resolved Hide resolved
src/components/module_parser.js Show resolved Hide resolved
src/components/module_parser.js Outdated Show resolved Hide resolved
src/components/i18n.js Outdated Show resolved Hide resolved
src/main.js Outdated Show resolved Hide resolved
src/main.js Outdated Show resolved Hide resolved
src/main.js Outdated Show resolved Hide resolved
src/main.js Outdated Show resolved Hide resolved
src/main.js Outdated Show resolved Hide resolved
src/manifest.json Show resolved Hide resolved
@eddex eddex mentioned this pull request Mar 6, 2020
Closed
@Lextum Lextum requested a review from eddex March 6, 2020 20:40
eddex
eddex reviewed Mar 9, 2020
View reviewed changes
src/_locales/de/messages.json Outdated Show resolved Hide resolved
src/_locales/en/messages.json Outdated Show resolved Hide resolved
src/main.js Outdated Show resolved Hide resolved
src/components/i18n.js Outdated Show resolved Hide resolved
src/components/i18n.js Show resolved Hide resolved
src/main.js Outdated Show resolved Hide resolved
@Lextum Lextum requested a review from eddex March 14, 2020 15:57
eddex
eddex reviewed Mar 16, 2020
View reviewed changes
Copy link
Owner

@eddex eddex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine but there are more comments to fix

eddex
eddex reviewed Mar 16, 2020
View reviewed changes
src/components/i18n.js Show resolved Hide resolved
src/components/i18n.js Show resolved Hide resolved
@eddex
Copy link
Owner

eddex commented Mar 24, 2020

would be great to finish this up.

@eddex eddex mentioned this pull request Mar 24, 2020
Closed
@eddex eddex changed the title Skipping invalid modules i18n and better handling for invalid modules Mar 25, 2020
@eddex eddex merged commit b092878 into master Mar 25, 2020
@eddex eddex deleted the fixForInternalHSLUModules branch March 25, 2020 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddex eddex eddex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lextum @eddex