Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 4 and 3.2 #17

Merged
merged 5 commits into from
Sep 16, 2017
Merged

Swift 4 and 3.2 #17

merged 5 commits into from
Sep 16, 2017

Conversation

eddiekaiger
Copy link
Owner

The biggest change in the Swift 4 conversion is the removal of Attribute.Name in favor of a new enum NSAttributedStringKey. The enum is essentially identical to Attribute.Name with the exception of Attribute.Name.textColor corresponding to NSAttributedStringKey.foregroundColor. As a result, very few (if any) projects will experience breaking changes.

Also, attribute(_:at:effectiveRange:) has been renamed to swiftyAttribute(_:at:effectiveRange:) to disambiguate itself from the same method found in Foundation.

This PR enables SwiftyAttributes to be built with both Swift 3.2 and Swift 4.0 in Xcode 9.

@codecov-io
Copy link

codecov-io commented Sep 16, 2017

Codecov Report

Merging #17 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   99.82%   99.86%   +0.03%     
==========================================
  Files          21       19       -2     
  Lines        1175     1448     +273     
==========================================
+ Hits         1173     1446     +273     
  Misses          2        2

@eddiekaiger eddiekaiger merged commit 33939dd into master Sep 16, 2017
@eddiekaiger eddiekaiger deleted the swift-4 branch September 16, 2017 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants