Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created += operator #31

Merged
merged 4 commits into from
Apr 23, 2019
Merged

Created += operator #31

merged 4 commits into from
Apr 23, 2019

Conversation

EmilioPelaez
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Feb 24, 2019

Codecov Report

Merging #31 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   99.73%   99.74%   +<.01%     
==========================================
  Files          10       10              
  Lines         377      385       +8     
==========================================
+ Hits          376      384       +8     
  Misses          1        1

@eddiekaiger
Copy link
Owner

@EmilioPelaez Thanks for the contribution! I know this might be slightly annoying but I'd like to maintain as much test coverage for the project as possible. Do you think you could test all variations of the operator? Perhaps you could write a helper function in the tests in which you could cast the attributed strings to either NSAttributedString or NSMutableAttributedString to test the variations.

@eddiekaiger
Copy link
Owner

Thanks @EmilioPelaez!

@eddiekaiger eddiekaiger merged commit a653915 into eddiekaiger:master Apr 23, 2019
@eddiekaiger
Copy link
Owner

Released in v5.1.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants