Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwinding support #70

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Unwinding support #70

wants to merge 9 commits into from

Conversation

Amanieu
Copy link
Collaborator

@Amanieu Amanieu commented Mar 23, 2017

See previous discussion in #52.

@Amanieu
Copy link
Collaborator Author

Amanieu commented Mar 24, 2017

One unresolved question is what to do about unfinished generators in the following cases with & without unwinding:

  • unwrap
  • unsafe_unwrap
  • drop

@carllerche
Copy link

Is this PR planned to be merged?

@edef1c
Copy link
Owner

edef1c commented Dec 16, 2018

@carllerche Yes, the main blocker is uncertainty about how this can be made to work well with -C panic=abort.

@carllerche
Copy link

Ok great. I would like to use fringe here: http://github.com/carllerche/loom

Right now I’m using a fork that includes this PR. It would also be great if fringe could work on stable :-)

@edef1c
Copy link
Owner

edef1c commented Dec 17, 2018

That's an exciting project! I'm afraid that getting libfringe to work on stable Rust would require stabilising inline assembly, though there are alternative (slower) approaches that could be implemented with similar APIs.

@carllerche
Copy link

@edef1c It would be nice if there were a stable (slower) option w/ a nightly feature flag. Right now, libfringe is the only Rust generator lib that does the right thing. generator-rs seems to SEGV if RUST_BACKTRACE=1 is specified.

cynecx added a commit to cynecx/libfringe that referenced this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants