Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/home page dark mode 1365 #1371

Merged
merged 13 commits into from
Oct 31, 2023
Merged

Feat/home page dark mode 1365 #1371

merged 13 commits into from
Oct 31, 2023

Conversation

Torresmorah
Copy link
Collaborator

@Torresmorah Torresmorah commented Oct 30, 2023 •
edited
Loading

Homepage Dark mode

What does this PR do?

  • Resolve Improve Home page design #1365
  • Add headings, fix accessibility errors
  • Refactor styles to define the color palette
  • Use dark mode as default and save user preference

Steps to test

  1. Run the homepage locally
  2. Test the dark mode

Screenshots

Desktop version

imagen
imagen

Mobile version

imagen

@Torresmorah Torresmorah added the WIP Work In Progress label Oct 30, 2023
@Torresmorah Torresmorah requested a review from xavier506 October 30, 2023 20:22
@Torresmorah Torresmorah self-assigned this Oct 30, 2023
@xavier506 xavier506 requested a review from Edwinjrc October 30, 2023 20:28
@Torresmorah Torresmorah removed the WIP Work In Progress label Oct 31, 2023
xavier506
xavier506 approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@xavier506 xavier506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xavier506 xavier506 merged commit 542266f into dev Oct 31, 2023
4 checks passed
@xavier506 xavier506 deleted the feat/home-page-dark-mode-1365 branch October 31, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavier506 xavier506 xavier506 approved these changes

@Edwinjrc Edwinjrc Awaiting requested review from Edwinjrc

Assignees

@Torresmorah Torresmorah

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Home page design
3 participants
@Torresmorah @xavier506 @code-factor