Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webapp): add enviroment variable #352

Merged
merged 4 commits into from
Dec 23, 2022

Conversation

JAMares
Copy link
Contributor

@JAMares JAMares commented Dec 23, 2022

Add enviroment variable

What does this PR do?

Steps to test

  1. Run Project
  2. Enter to delegate or try login, must see this:
    imagen

CheckList

  • Follow proper Markdown format
  • The content is adequate
  • The content is available in both english and spanish
  • I Ran a spell check

@JAMares JAMares added bug Something isn't working frontend Webapp Develop labels Dec 23, 2022
@JAMares JAMares self-assigned this Dec 23, 2022
@gitguardian
Copy link

gitguardian bot commented Dec 23, 2022

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
4577043 Generic High Entropy Secret 4d3d15a .env.example View secret
4577043 Generic High Entropy Secret a1c776f .env.example View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

.env.example Outdated Show resolved Hide resolved
@xavier506 xavier506 self-requested a review December 23, 2022 17:42
Copy link
Contributor

@xavier506 xavier506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xavier506 xavier506 merged commit c780998 into dev Dec 23, 2022
@xavier506 xavier506 deleted the fix/update-delegate-verification-351 branch December 23, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Webapp Develop
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update delegate verification link
2 participants