Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added name and description parameters to import_group #1153

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

edgarrmondragon
Copy link
Owner

@edgarrmondragon edgarrmondragon commented May 29, 2024

Summary

Added name and description parameters to import_group: https://api.limesurvey.org/classes/remotecontrol-handle.html#method_import_group.

Closes #1156

Blockers:

Test Plan

Added new integration tests.

Checklist

  • My pull request has a descriptive title.
  • I have read the CONTRIBUTING guide.
  • I have added tests that prove my fix is effective or that my feature works.
  • If appropriate, I have added necessary documentation.
  • For user-facing changes, refactorings, performance improvements or documentation updates, I have added a changelog entry using Changie.

For both the title of the PR and the changelog entry, prefer simple past tense or constructions with "now". For example:

  • Added Client.invite_participants()
  • Client.user_activation_settings() now accepts a user_activation_settings keyword argument

📚 Documentation preview 📚: https://citric--1153.org.readthedocs.build/en/1153/

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (70523dd) to head (429aef0).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1153   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          482       482           
  Branches        25        25           
=========================================
  Hits           482       482           
Flag Coverage Δ
integration 91.28% <ø> (ø)
unit 93.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the feat/import-group-name-description branch from 1f22931 to b3afedf Compare May 29, 2024 23:52
Copy link

sonarcloud bot commented Jul 3, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add name and description parameters of import_group
1 participant