Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Restructure package to accomodate both RPC and REST clients #995

Draft
wants to merge 57 commits into
base: main
Choose a base branch
from

Conversation

edgarrmondragon
Copy link
Owner

@edgarrmondragon edgarrmondragon commented Sep 20, 2023

git diff main:src/citric/client.py HEAD:src/citric/rpc/client.py
git diff main:src/citric/session.py HEAD:src/citric/rpc/session.py
git diff main:src/citric/method.py HEAD:src/citric/rpc/method.py

📚 Documentation preview 📚: https://citric--995.org.readthedocs.build/en/995/

@trunk-io
Copy link

trunk-io bot commented Sep 20, 2023

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@edgarrmondragon edgarrmondragon force-pushed the break/restructure-package-both-clients branch 2 times, most recently from 3c6645c to 5002f6d Compare September 20, 2023 08:47
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (882b341) 100.00% compared to head (24b8afa) 99.62%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/citric/rpc/client.py 99.18% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main     #995      +/-   ##
===========================================
- Coverage   100.00%   99.62%   -0.38%     
===========================================
  Files           10       14       +4     
  Lines          482      535      +53     
  Branches        24       29       +5     
===========================================
+ Hits           482      533      +51     
- Partials         0        2       +2     
Flag Coverage Δ
integration 91.77% <89.40%> (+0.48%) ⬆️
unit 93.83% <92.11%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the break/restructure-package-both-clients branch from 5002f6d to d90a191 Compare September 20, 2023 09:15
@edgarrmondragon edgarrmondragon force-pushed the break/restructure-package-both-clients branch from d90a191 to 0478f5a Compare September 20, 2023 14:39
@edgarrmondragon edgarrmondragon force-pushed the break/restructure-package-both-clients branch from 0478f5a to 65fa6c0 Compare September 20, 2023 23:58
@edgarrmondragon edgarrmondragon force-pushed the break/restructure-package-both-clients branch 2 times, most recently from 1a6e3d7 to e32ae70 Compare September 21, 2023 00:18
@edgarrmondragon edgarrmondragon force-pushed the break/restructure-package-both-clients branch from e32ae70 to caf1505 Compare September 21, 2023 00:20
Base automatically changed from feat/rest-api to main November 29, 2023 02:31
Repository owner deleted a comment from sonarcloud bot Nov 29, 2023
@edgarrmondragon
Copy link
Owner Author

git diff main:src/citric/client.py HEAD:src/citric/rpc/client.py
git diff main:src/citric/session.py HEAD:src/citric/rpc/session.py
git diff main:src/citric/method.py HEAD:src/citric/rpc/method.py

Repository owner deleted a comment from sonarcloud bot Jan 3, 2024
Copy link

sonarcloud bot commented Jan 25, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@edgarrmondragon edgarrmondragon added this to the REST API Support milestone May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
REST Issues related to the REST client implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant