Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Make importlib-resources a dev dependency and remove the SCHEMA_FILE constant from the public API #36

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,12 @@ dynamic = [
"version",
]
dependencies = [
'importlib-resources>=5.3; python_version < "3.9"',
]
optional-dependencies.dev = [
"coverage[toml]>=6.5",
"hypothesis",
"hypothesis-jsonschema",
'importlib-resources>=5.3; python_version < "3.9"',
"pytest",
]
optional-dependencies.docs = [
Expand Down
8 changes: 1 addition & 7 deletions src/pep610/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,13 @@

import hashlib
import json
import sys
import typing as t
from dataclasses import dataclass
from functools import singledispatch
from importlib.metadata import version

if sys.version_info < (3, 9):
import importlib_resources
else:
import importlib.resources as importlib_resources

if t.TYPE_CHECKING:
import sys
from importlib.metadata import Distribution, PathDistribution

if sys.version_info <= (3, 10):
Expand Down Expand Up @@ -46,7 +41,6 @@
"write_to_distribution",
]

SCHEMA_FILE = importlib_resources.files(__package__) / "direct_url.schema.json"
__version__ = version(__package__)


Expand Down
9 changes: 8 additions & 1 deletion tests/test_generic.py
Original file line number Diff line number Diff line change
@@ -1,12 +1,19 @@
import json
import sys
from importlib.metadata import Distribution

import pytest
from hypothesis import HealthCheck, given, settings
from hypothesis_jsonschema import from_schema

from pep610 import SCHEMA_FILE, read_from_distribution, write_to_distribution
from pep610 import read_from_distribution, write_to_distribution

if sys.version_info < (3, 9):
import importlib_resources
else:
import importlib.resources as importlib_resources

SCHEMA_FILE = importlib_resources.files(__package__) / "fixtures/direct_url.schema.json"
SCHEMA = json.loads(SCHEMA_FILE.read_text())


Expand Down