Clean up performance test #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robszumski
previously approved these changes
Aug 30, 2023
The spirit of the test remains the same - test the throughput of a simple webserver, which has to do some amount of computation, within an enclave - but the implementation has been simplified. The documentation and scripts have also been cleaned up to simplify the setup and execution of the test. During testing, I was able to achieve almost 500 requests per second for both two and four vCPUs. This is mainly due to the fact that the ramp-up time is set to 20 seconds (the full test runs take 24 seconds). As I increase the amount of busy-looping per request, I start to see more errors (and it's not immediately obvious what constitutes an error). I'm leaving the test and the result as is and will follow up with a better benchmark implementation.
|
I replaced the encryption with a busy loop to simplify the implementation (and to better control how long each request takes). We aren't benchmarking Golang's encryption implementation, so I wanted to remove that variable from the picture. |
robszumski
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spirit of the test remains the same - test the throughput of a simple webserver, which has to do some amount of computation, within an enclave - but the implementation has been simplified. The documentation and scripts have also been cleaned up to simplify the setup and execution of the test.