Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cloud-credentials/secret_key parsing #256

Merged
merged 5 commits into from
Dec 29, 2022
Merged

Add cloud-credentials/secret_key parsing #256

merged 5 commits into from
Dec 29, 2022

Conversation

fmoor
Copy link
Member

@fmoor fmoor commented Dec 22, 2022

@fmoor fmoor requested a review from fantix December 22, 2022 20:39
@fmoor fmoor marked this pull request as ready for review December 28, 2022 19:12
Copy link
Member

@fantix fantix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the 2 comments, this looks good to me 👍

internal/client/connutils.go Outdated Show resolved Hide resolved
internal/client/connutils.go Outdated Show resolved Hide resolved
fmoor added a commit to edgedb/shared-client-testcases that referenced this pull request Dec 29, 2022
fmoor added a commit to edgedb/shared-client-testcases that referenced this pull request Dec 29, 2022
@fmoor fmoor merged commit 014bff7 into master Dec 29, 2022
@fmoor fmoor deleted the secret-key branch December 29, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants