Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Generate queries) Add ignore require-await rule for deno exports #672

Closed
PastelStoic opened this issue Jun 30, 2023 · 4 comments
Closed

Comments

@PastelStoic
Copy link
Contributor

Due to the output structure, the default deno linter complains about the generated queries not using await. Adding
// deno-lint-ignore-file require-await
to each generated file would prevent this error.

@scotttrinh
Copy link
Collaborator

Thanks for the report! PRs welcome, but I put it in my backlog if no one else gets to it in the next few weeks.

@davepar
Copy link

davepar commented Dec 12, 2023

Just a friendly ping that this is still an issue. The merged PR is adding a deno-lint-ignore-file for the file, but it's after an import type statement. This causes deno to ignore it. The line doesn't have to be at the top, but does need to be before any statements. See the deno docs for details.

I can try this minor fix if nobody else is looking at it.

@PastelStoic
Copy link
Contributor Author

Now that I look more closely - is the async keyword actually needed? A promise is returned with or without it.

@scotttrinh
Copy link
Collaborator

Fixed in #812

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants