Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added linting rule for deno #675

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Added linting rule for deno #675

merged 2 commits into from
Jul 7, 2023

Conversation

PastelStoic
Copy link
Contributor

Simple fix for #672. I'm slightly worried about the newline literal causing some weird pitfall with windows somehow.

@edgedb-cla
Copy link

edgedb-cla bot commented Jul 3, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

@scotttrinh
Copy link
Collaborator

@PastelStoic

Thanks for the suggestion here! Perhaps what we want is a denoImpl that just imports the tsImpl to make that assignment a little easier to grok. Do you want to take a swing at that? Otherwise, I can make the change myself when merging.

@PastelStoic
Copy link
Contributor Author

PastelStoic commented Jul 3, 2023

Thanks for the suggestion here! Perhaps what we want is a denoImpl that just imports the tsImpl to make that assignment a little easier to grok. Do you want to take a swing at that? Otherwise, I can make the change myself when merging.

Done.

Copy link
Collaborator

@scotttrinh scotttrinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@scotttrinh scotttrinh merged commit 57a5b25 into edgedb:master Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants