Add codecs for ext::pgvector::halfvec+ext::pgvector::sparsevec and add SparseVector datatype
#1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yeah, I think this is great, and we can remove it once it ever hits baseline support, but that's likely years away at this point. FWIW, the official pgvector package itself just uses a number array for both regular and sparse vectors so this is already a huge improvement over that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1123
For the
halfvectype, decoding toFloat16Arrayseems like the correct thing (similar to decodingvectortype tpFloat32Array), but it currently seems unsupported everywhere except deno (and firefox), so I've bundled aFloat16Arraypolyfill: https://www.npmjs.com/package/@petamoriken/float16. (For deno it uses the native implementation via the adaptor). @scotttrinh Does this seem ok? We could also make users provide their own polyfill, but since nothing supports it currently and there seems to be no types for it in ts, bundling it seems easier.