Add ai rag provider #1129
Open
Add ai rag provider #1129
+2,213
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
scotttrinh
reviewed
Nov 6, 2024
Use default prompt if prompt.custom is not provided, but messages are.
scotttrinh
reviewed
Nov 18, 2024
| | ContentBlockStop | ||
| | MessageDelta | ||
| | MessageStop; | ||
| const _edgedbRagChunkSchema = z.discriminatedUnion("type", [ |
There was a problem hiding this comment.
We are not exporting this Zod schema or using it in this file: why are we using a Zod schema instead of writing this as a TypeScript interface?
There was a problem hiding this comment.
I used this in the vercel provider so it was easier to copy paste it.
packages/ai/src/core.ts
Outdated
| @@ -68,11 +63,17 @@ export class EdgeDBAI { | |||
| }); | |||
| } | |||
|
|
|||
| private async fetchRag(request: Omit<RAGRequest, "model" | "prompt">) { | |||
| private async fetchRag(request: any) { | |||
There was a problem hiding this comment.
Is there something more useful than any we can use here? Like maybe unknown?
There was a problem hiding this comment.
tnx, I updated this
| export async function createEdgeDB(client: Client): Promise<EdgeDBProvider> { | ||
| const connectConfig: ResolvedConnectConfig = ( | ||
| await (client as any).pool._getNormalizedConnectConfig() | ||
| ).connectionParams; |
There was a problem hiding this comment.
I think we have a new API for getting these on the Client object. Like getConnectionParams or something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.