Handle >2 union members in links #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotttrinh
commented
Jun 26, 2023
| @@ -158,93 +158,15 @@ export const getStringRepresentation: ( | |||
| export const generateObjectTypes = (params: GeneratorParams) => { | |||
| const { dir, types } = params; | |||
|
|
|||
| // const plainTypesCode = dir.getPath("types"); | |||
There was a problem hiding this comment.
Yeah, I'm just killing all this commented out code: it's already drifting pretty far, so I don't think it makes much sense to keep it.
scotttrinh
commented
Jun 26, 2023
| continue; | ||
| } | ||
|
|
||
| const isUnionType = Boolean(type.union_of?.length); | ||
| const isIntersectionType = Boolean(type.intersection_of?.length); | ||
|
|
||
| if (isIntersectionType) { | ||
| if (isIntersectionType || isUnionType) { |
There was a problem hiding this comment.
Here's the actual fix: we just skip generating any type if it's actually a union instead of a separate type.
scotttrinh
force-pushed
the
646-many-union-members
branch
from
8222337
to
31e25af
Compare
scotttrinh
commented
Jun 26, 2023
| @@ -274,7 +274,7 @@ SELECT (SELECT __param__test)` | |||
| tuple: args, | |||
| }); | |||
|
|
|||
| assert.deepEqual(Object.values(complexResult.tuple), Object.values(args)); | |||
| assert.deepEqual(complexResult.tuple, args); | |||
There was a problem hiding this comment.
This changed for no good reason, but our macos tests were failing with a test timeout until I did this update. 🫠
scotttrinh
force-pushed
the
646-many-union-members
branch
from
31e25af
to
c4fcad3
Compare
scotttrinh
force-pushed
the
test-multiple-versions
branch
from
f6836cc
to
da6e8dc
Compare
scotttrinh
force-pushed
the
646-many-union-members
branch
from
21d9100
to
2c91512
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not need to generate a separate object type for a type that is a union of other types since we will have already generated the individual types and the use of that type within another type will be handled by the declaration of the consumer of the union.
TODO: