Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid copying existing buffer in base64 encoder #676

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Avoid copying existing buffer in base64 encoder #676

merged 3 commits into from
Nov 30, 2023

Conversation

scotttrinh
Copy link
Collaborator

Closes #674

Avoid copying an existing buffer when encoding buffer data as base64. Also prioritizes using Buffer instead of btoa if both exist.

@scotttrinh scotttrinh merged commit 78bc393 into master Nov 30, 2023
8 checks passed
@scotttrinh scotttrinh deleted the 674-avoid-buffer-copy branch November 30, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If you want to make EdgeDB's base64 encode function faster & use less memory
1 participant
@scotttrinh