Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add any existing ext::* scalar to a type's __casttype__ #686

Merged
merged 6 commits into from
Jul 11, 2023
Merged

Add any existing ext::* scalar to a type's __casttype__ #686

merged 6 commits into from
Jul 11, 2023

Commits on Jul 11, 2023

  1. Add exemplary test case

    @scotttrinh
    scotttrinh committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    976bf5b View commit details
    Browse the repository at this point in the history

  2. Improve error message in function overload getter

    @scotttrinh
    scotttrinh committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    e0b8225 View commit details
    Browse the repository at this point in the history

  3. Include extensions in "material_scalars" query

    @scotttrinh
    scotttrinh committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    aec6ebf View commit details
    Browse the repository at this point in the history

  4. Remove stray console.log

    @scotttrinh
    scotttrinh committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    dba99dd View commit details
    Browse the repository at this point in the history

  5. Filter out any types with non-abstract ancestors

    @scotttrinh
    scotttrinh committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    992f2f0 View commit details
    Browse the repository at this point in the history

  6. Remove useless name filtering 

    Checked the results locally, and they seem sensible. Only additional
scalar is the `cfg::Memory` scalar, which seems fine to include here
    @scotttrinh
    scotttrinh committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    84fe7d1 View commit details
    Browse the repository at this point in the history