Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix createHttpClient not using secretKey when connecting to cloud instances #698

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Fix createHttpClient not using secretKey when connecting to cloud instances #698

merged 2 commits into from
Jul 25, 2023

Conversation

jaclarke
Copy link
Member

No description provided.

@jaclarke jaclarke requested a review from scotttrinh July 25, 2023 11:46
scotttrinh
scotttrinh approved these changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@scotttrinh scotttrinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Changes look good. I'll look at beefing up our tests to cover this config stuff since it's starting to get a little more interesting now.

@scotttrinh scotttrinh merged commit 3187854 into master Jul 25, 2023
@scotttrinh scotttrinh deleted the fix-httpclient-secretkey branch July 25, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diksipav diksipav diksipav approved these changes

@scotttrinh scotttrinh scotttrinh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaclarke @scotttrinh @diksipav