Add basic support for protocol v2 #710
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`noUnusedLocals` is false by default, so we needed to set it in config
I don't recall what this was about, but it was causing all of the deno files to be missing.
scotttrinh
reviewed
Aug 30, 2024
I will try to add these tomorrow: Documentation is missing: - SNI, - Cloud Profile, - tlsCA maybe should be documented too, - `credentials` is not documented. **More things to be done**: add SNI to credentials.json in the cli, and later read it from there: `Oh and to address this specifically, although very marginal, we may want to update the CLI to include tls_server_name in credentials.json if --tls-server-name was specified while linking an instance.` Atm CLOUD_PROFILE is taken from env var when using options. And when using env vars it is not used at all? --------- Co-authored-by: Scott Trinh <scott@edgedb.com>
jaclarke
added a commit
to edgedb/edgedb
that referenced
this pull request
Sep 4, 2024
…ersion in the response `content-type` header (#7701) Currently the `content-type` header of the response for the binary over http protocol, always contains the latest protocol version supported by the server, even if the client requested an older protocol version and the response data actually being encoded using that requested version. The current edgedb-js client which still uses protocol v1, just happens to work despite this bug, as it also has a bug that results in it ignoring the incorrect protocol version header from the server and assuming it's the version requested. (Will be fixed in edgedb/edgedb-js#710)
|
Closed in favor of #1091 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.