Remove extra flattening of array literal #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating compatibility with the latest version of TypeScript (5.3.3 at the moment), I was working against the
mainbranch of TypeScript and found a case wheree.literalwas causing aTS2589: Type instantiation is excessively deep and possibly infinite.error.There are additional issues on 5.3.3, but this was one that was detectable and fixable in isolation, so adding this fix now. Might be a fix for #782 but I haven't been able to repro that issue.
Not sure why there is a benchmark regression here. I'm also getting this against
master, so maybe there are some weird environmental issues that affect the benchmarks and make them slightly non-deterministic? 🤷