Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes #413

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Minor changes #413

merged 2 commits into from
Jan 31, 2023

Conversation

0xsirsaif
Copy link
Contributor

No description provided.

@edgedb-cla
Copy link

edgedb-cla bot commented Jan 27, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

Co-authored-by: Devon Campbell <devon@radworks.io>
@raddevon
Copy link
Contributor

Looks great! If you are able to sign our CLA, I will get this merged for you.

@0xsirsaif
Copy link
Contributor Author

@raddevon Yes, how am I supposed to do this? Are there particular instructions on how to sign?

@raddevon
Copy link
Contributor

@0xsirsaif If you scroll down the list of checks at the bottom of the pull request, you should see the CLA check. Click the "Details" link to see the CLA. Scroll to the bottom of that to "sign" by logging in with the same GitHub account you used to submit the PR.

Here's a screenshot:
CleanShot 2023-01-30 at 08 39 49@2x

@0xsirsaif
Copy link
Contributor Author

@raddevon I just signed the cla, thank you for your response.

@raddevon raddevon merged commit 231bf57 into edgedb:master Jan 31, 2023
@raddevon
Copy link
Contributor

@0xsirsaif Awesome! Thank you for contributing!

fantix pushed a commit that referenced this pull request Feb 9, 2023
* usage.rst & asyncio_client.rst

* Update docs/api/asyncio_client.rst

Co-authored-by: Devon Campbell <devon@radworks.io>

---------

Co-authored-by: Devon Campbell <devon@radworks.io>
fantix added a commit that referenced this pull request Feb 9, 2023
Changes
=======

* Add support for secret key authentication, and Cloud instance (#405)
  (by @fantix in df1f6fb, 076e8c8, 27e7a4f for #405, @elprans in 65c9c37 for #412)

Docs
====

* Minor changes (#413)
  (by @0xsirsaif in 14363fb for #413)
@fantix fantix mentioned this pull request Feb 9, 2023
@aljazerzen aljazerzen mentioned this pull request Feb 23, 2024
This was referenced Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants