Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the vector tests to match the final PR #440

Merged
merged 2 commits into from
Jun 9, 2023
Merged

Fix the vector tests to match the final PR #440

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf25764
Fix the vector tests to match the final PR
msullivan Jun 9, 2023
c75a259
don't be explicit about the version
msullivan Jun 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 17 additions & 27 deletions tests/test_vector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,106 +36,96 @@ def setUp(self):

if not self.client.query_required_single('''
select exists (
select sys::ExtensionPackage filter .name = 'vector'
select sys::ExtensionPackage filter .name = 'pgvector'
)
'''):
self.skipTest("feature not implemented")

self.client.execute('''
create extension vector version '1.0'
create extension pgvector;
''')

def tearDown(self):
try:
self.client.execute('''
drop extension vector version '1.0'
drop extension pgvector;
''')
finally:
super().tearDown()

async def test_vector_01(self):
# if not self.client.query_required_single('''
# select exists (
# select sys::ExtensionPackage filter .name = 'vector'
# )
# '''):
# self.skipTest("feature not implemented")

# self.client.execute('''
# create extension vector version '1.0'
# ''')

val = self.client.query_single('''
select <vector::vector>'[1.5,2.0,3.8]'
select <ext::pgvector::vector>[1.5,2.0,3.8]
''')
self.assertTrue(isinstance(val, array.array))
self.assertEqual(val, array.array('f', [1.5, 2.0, 3.8]))

val = self.client.query_single(
'''
select <str><vector::vector>$0
select <json><ext::pgvector::vector>$0
''',
[3.0, 9.0, -42.5],
)
self.assertEqual(val, '[3,9,-42.5]')
self.assertEqual(val, '[3, 9, -42.5]')

val = self.client.query_single(
'''
select <str><vector::vector>$0
select <json><ext::pgvector::vector>$0
''',
array.array('f', [3.0, 9.0, -42.5])
)
self.assertEqual(val, '[3,9,-42.5]')
self.assertEqual(val, '[3, 9, -42.5]')

val = self.client.query_single(
'''
select <str><vector::vector>$0
select <json><ext::pgvector::vector>$0
''',
array.array('i', [1, 2, 3]),
)
self.assertEqual(val, '[1,2,3]')
self.assertEqual(val, '[1, 2, 3]')

# Test that the fast-path works: if the encoder tries to
# call __getitem__ on this brokenarray, it will fail.
val = self.client.query_single(
'''
select <str><vector::vector>$0
select <json><ext::pgvector::vector>$0
''',
brokenarray('f', [3.0, 9.0, -42.5])
)
self.assertEqual(val, '[3,9,-42.5]')
self.assertEqual(val, '[3, 9, -42.5]')

# I don't think it's worth adding a dependency to test this,
# but this works too:
# import numpy as np
# val = self.client.query_single(
# '''
# select <str><vector::vector>$0
# select <json><ext::pgvector::vector>$0
# ''',
# np.asarray([3.0, 9.0, -42.5], dtype=np.float32),
# )
# self.assertEqual(val, '[3,9,-42.5]')

# Some sad path tests
with self.assertRaises(edgedb.InvalidArgumentError):
self.client.query_single(
'''
select <vector::vector>$0
select <ext::pgvector::vector>$0
''',
[3.0, None, -42.5],
)

with self.assertRaises(edgedb.InvalidArgumentError):
self.client.query_single(
'''
select <vector::vector>$0
select <ext::pgvector::vector>$0
''',
[3.0, 'x', -42.5],
)

with self.assertRaises(edgedb.InvalidArgumentError):
self.client.query_single(
'''
select <vector::vector>$0
select <ext::pgvector::vector>$0
''',
'foo',
)